Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default empty string #30887

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

Neo-MS
Copy link

@Neo-MS Neo-MS commented Feb 25, 2025

Related command

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature


This checklist is used to make sure that common guidelines for a pull request are followed.

Copy link

Validation for Azure CLI Full Test Starting...

Thanks for your contribution!

Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 25, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Feb 25, 2025
Copy link
Contributor

Thank you for your contribution Neo-MS! We will review the pull request and get back to you soon.

@@ -42,8 +42,8 @@
CONST_AVAILABILITY_SET = "AvailabilitySet"

# vm size
CONST_DEFAULT_NODE_VM_SIZE = "Standard_DS2_v2"
CONST_DEFAULT_WINDOWS_NODE_VM_SIZE = "Standard_D2s_v3"
CONST_DEFAULT_NODE_VM_SIZE = ""
Copy link
Member

@FumingZhang FumingZhang Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a breaking change. People are only allowed to make breaking changes during Build/Ignite events.

BTW, could you please add some test for this change? I tested it locally and it's not working as expected (rp refused to choose a proper vm size for me, instead it returns an error).

Code: VMSizeNotSupported
Message: Virtual Machine size: '' is not supported for subscription 79a7390d-3a85-432d-9f6f-a11a703c8b83 in location 'westus2'. The available VM sizes are 'standard_a2_v2,standard_a2m_v2,standard_a4_v2,standard_a4m_v2,standard_a8_v2,standard_a8m_v2,standard_b12ms,standard_b16als_v2,standard_b16as_v2,standard_b16ls_v2,standard_b16ms,standard_b16pls_v2,standard_b16ps_v2,standard_b16s_v2,standard_b20ms,standard_b2als_v2,standard_b2as_v2,standard_b2ats_v2,standard_b2ls_v2,standard_b2ms,standard_b2pls_v2,standard_b2ps_v2,standard_b2pts_v2,standard_b2s,standard_b2s_v2,standard_b2ts_v2,standard_b32als_v2,standard_b32as_v2,standard_b32ls_v2,standard_b32s_v2,standard_b4als_v2,standard_b4as_v2,standard_b4ls_v2,standard_b4ms,standard_b4pls_v2,standard_b4ps_v2,standard_b4s_v2,standard_b8als_v2,standard_b8as_v2,standard_b8ls_v2,standard_b8ms,standard_b8pls_v2,standard_b8ps_v2,standard_b8s_v2,standard_d11_v2,standard_d12_v2,standard_d13_v2,standard_d14_v2,standard_d16_v3,standard_d16_v4,standard_d16_v5,standard_d16a_v4,standard_d16ads_v5,standard_d16as_v4,standard_d16as_v5,standard_d16d_v4,standard_d16d_v5,standard_d16ds_v4,standard_d16ds_v5,standard_d16lds_v5,standard_d16ls_v5,standard_d16pds_v5,standard_d16pds_v6,standard_d16plds_v5,standard_d16plds_v6,standard_d16pls_v5,standard_d16pls_v6,standard_d16ps_v5,standard_d16ps_v6,standard_d16s_v3,standard_d16s_v4,standard_d16s_v5,standard_d2_v2,standard_d2_v3,standard_d2_v4,standard_d2_v5,standard_d2a_v4,standard_d2ads_v5,standard_d2as_v4,standard_d2as_v5,standard_d2d_v4,standard_d2d_v5,standard_d2ds_v4,standard_d2ds_v5,standard_d2lds_v5,standard_d2ls_v5,standard_d2pds_v5,standard_d2pds_v6,standard_d2plds_v5,standard_d2plds_v6,standard_d2pls_v5,standard_d2pls_v6,standard_d2ps_v5,standard_d2ps_v6,standard_d2s_v3,standard_d2s_v4,standard_d2s_v5,standard_d32_v3,standard_d32_v4,standard_d32_v5,standard_d32a_v4,standard_d32ads_v5,standard_d32as_v4,standard_d32as_v5,standard_d32d_v4,standard_d32d_v5,standard_d32ds_v4,standard_d32ds_v5,standard_d32lds_v5,standard_d32ls_v5,standard_d32pds_v5,standard_d32pds_v6,standard_d32plds_v5,standard_d32plds_v6,standard_d32pls_v5,standard_d32pls_v6,standard_d32ps_v5,standard_d32ps_v6,standard_d32s_v3,standard_d32s_v4,standard_d32s_v5,standard_d3_v2,standard_d48_v3,standard_d48_v4,standard_d48_v5,standard_d48a_v4,standard_d48ads_v5,standard_d48as_v4,standard_d48as_v5,standard_d48d_v4,standard_d48d_v5,standard_d48ds_v4,standard_d48ds_v5,standard_d48lds_v5,standard_d48ls_v5,standard_d48pds_v5,standard_d48pds_v6,standard_d48plds_v5,standard_d48plds_v6,standard_d48pls_v5,standard_d48pls_v6,standard_d48ps_v5,standard_d48ps_v6,standard_d48s_v3,standard_d48s_v4,standard_d48s_v5,standard_d4_v2,standard_d4_v3,standard_d4_v4,standard_d4_v5,standard_d4a_v4,standard_d4ads_v5,standard_d4as_v4,standard_d4as_v5,standard_d4d_v4,standard_d4d_v5,standard_d4ds_v4,standard_d4ds_v5,standard_d4lds_v5,standard_d4ls_v5,standard_d4pds_v5,standard_d4pds_v6,standard_d4plds_v5,standard_d4plds_v6,standard_d4pls_v5,standard_d4pls_v6,standard_d4ps_v5,standard_d4ps_v6,standard_d4s_v3,standard_d4s_v4,standard_d4s_v5,standard_d5_v2,standard_d64_v3,standard_d64_v4,standard_d64_v5,standard_d64a_v4,standard_d64ads_v5,standard_d64as_v4,standard_d64as_v5,standard_d64d_v4,standard_d64d_v5,standard_d64ds_v4,standard_d64ds_v5,standard_d64lds_v5,standard_d64ls_v5,standard_d64pds_v5,standard_d64pds_v6,standard_d64plds_v5,standard_d64plds_v6,standard_d64pls_v5,standard_d64pls_v6,standard_d64ps_v5,standard_d64ps_v6,standard_d64s_v3,standard_d64s_v4,standard_d64s_v5,standard_d8_v3,standard_d8_v4,standard_d8_v5,standard_d8a_v4,standard_d8ads_v5,standard_d8as_v4,standard_d8as_v5,standard_d8d_v4,standard_d8d_v5,standard_d8ds_v4,standard_d8ds_v5,standard_d8lds_v5,standard_d8ls_v5,standard_d8pds_v5,standard_d8pds_v6,standard_d8plds_v5,standard_d8plds_v6,standard_d8pls_v5,standard_d8pls_v6,standard_d8ps_v5,standard_d8ps_v6,standard_d8s_v3,standard_d8s_v4,standard_d8s_v5,standard_d96_v5,standard_d96a_v4,standard_d96ads_v5,standard_d96as_v4,standard_d96as_v5,standard_d96d_v5,standard_d96ds_v5,standard_d96lds_v5,standard_d96ls_v5,standard_d96pds_v6,standard_d96plds_v6,standard_d96pls_v6,standard_d96ps_v6,standard_d96s_v5,standard_dc16ds_v3,standard_dc16s_v3,standard_dc24ds_v3,standard_dc24s_v3,standard_dc2ds_v3,standard_dc2s_v2,standard_dc2s_v3,standard_dc32ds_v3,standard_dc32s_v3,standard_dc48ds_v3,standard_dc48s_v3,standard_dc4ds_v3,standard_dc4s_v2,standard_dc4s_v3,standard_dc8_v2,standard_dc8ds_v3,standard_dc8s_v3,standard_ds11-1_v2,standard_ds11_v2,standard_ds12-1_v2,standard_ds12-2_v2,standard_ds12_v2,standard_ds13-2_v2,standard_ds13-4_v2,standard_ds13_v2,standard_ds14-4_v2,standard_ds14-8_v2,standard_ds14_v2,standard_ds2_v2,standard_ds3_v2,standard_ds4_v2,standard_ds5_v2,standard_e104i_v5,standard_e104id_v5,standard_e104ids_v5,standard_e104is_v5,standard_e112iads_v5,standard_e112ias_v5,standard_e112ibds_v5,standard_e112ibs_v5,standard_e16-4ads_v5,standard_e16-4as_v4,standard_e16-4as_v5,standard_e16-4ds_v4,standard_e16-4ds_v5,standard_e16-4s_v3,standard_e16-4s_v4,standard_e16-4s_v5,standard_e16-8ads_v5,standard_e16-8as_v4,standard_e16-8as_v5,standard_e16-8ds_v4,standard_e16-8ds_v5,standard_e16-8s_v3,standard_e16-8s_v4,standard_e16-8s_v5,standard_e16_v3,standard_e16_v4,standard_e16_v5,standard_e16a_v4,standard_e16ads_v5,standard_e16as_v4,standard_e16as_v5,standard_e16bds_v5,standard_e16bs_v5,standard_e16d_v4,standard_e16d_v5,standard_e16ds_v4,standard_e16ds_v5,standard_e16pds_v5,standard_e16pds_v6,standard_e16ps_v5,standard_e16ps_v6,standard_e16s_v3,standard_e16s_v4,standard_e16s_v5,standard_e20_v3,standard_e20_v4,standard_e20_v5,standard_e20a_v4,standard_e20ads_v5,standard_e20as_v4,standard_e20as_v5,standard_e20d_v4,standard_e20d_v5,standard_e20ds_v4,standard_e20ds_v5,standard_e20pds_v5,standard_e20ps_v5,standard_e20s_v3,standard_e20s_v4,standard_e20s_v5,standard_e2_v3,standard_e2_v4,standard_e2_v5,standard_e2a_v4,standard_e2ads_v5,standard_e2as_v4,standard_e2as_v5,standard_e2bds_v5,standard_e2bs_v5,standard_e2d_v4,standard_e2d_v5,standard_e2ds_v4,standard_e2ds_v5,standard_e2pds_v5,standard_e2pds_v6,standard_e2ps_v5,standard_e2ps_v6,standard_e2s_v3,standard_e2s_v4,standard_e2s_v5,standard_e32-16ads_v5,standard_e32-16as_v4,standard_e32-16as_v5,standard_e32-16ds_v4,standard_e32-16ds_v5,standard_e32-16s_v3,standard_e32-16s_v4,standard_e32-16s_v5,standard_e32-8ads_v5,standard_e32-8as_v4,standard_e32-8as_v5,standard_e32-8ds_v4,standard_e32-8ds_v5,standard_e32-8s_v3,standard_e32-8s_v4,standard_e32-8s_v5,standard_e32_v3,standard_e32_v4,standard_e32_v5,standard_e32a_v4,standard_e32ads_v5,standard_e32as_v4,standard_e32as_v5,standard_e32bds_v5,standard_e32bs_v5,standard_e32d_v4,standard_e32d_v5,standard_e32ds_v4,standard_e32ds_v5,standard_e32pds_v5,standard_e32pds_v6,standard_e32ps_v5,standard_e32ps_v6,standard_e32s_v3,standard_e32s_v4,standard_e32s_v5,standard_e4-2ads_v5,standard_e4-2as_v4,standard_e4-2as_v5,standard_e4-2ds_v4,standard_e4-2ds_v5,standard_e4-2s_v3,standard_e4-2s_v4,standard_e4-2s_v5,standard_e48_v3,standard_e48_v4,standard_e48_v5,standard_e48a_v4,standard_e48ads_v5,standard_e48as_v4,standard_e48as_v5,standard_e48bds_v5,standard_e48bs_v5,standard_e48d_v4,standard_e48d_v5,standard_e48ds_v4,standard_e48ds_v5,standard_e48pds_v6,standard_e48ps_v6,standard_e48s_v3,standard_e48s_v4,standard_e48s_v5,standard_e4_v3,standard_e4_v4,standard_e4_v5,standard_e4a_v4,standard_e4ads_v5,standard_e4as_v4,standard_e4as_v5,standard_e4bds_v5,standard_e4bs_v5,standard_e4d_v4,standard_e4d_v5,standard_e4ds_v4,standard_e4ds_v5,standard_e4pds_v5,standard_e4pds_v6,standard_e4ps_v5,standard_e4ps_v6,standard_e4s_v3,standard_e4s_v4,standard_e4s_v5,standard_e64-16ads_v5,standard_e64-16as_v4,standard_e64-16as_v5,standard_e64-16ds_v4,standard_e64-16ds_v5,standard_e64-16s_v3,standard_e64-16s_v4,standard_e64-16s_v5,standard_e64-32ads_v5,standard_e64-32as_v4,standard_e64-32as_v5,standard_e64-32ds_v4,standard_e64-32ds_v5,standard_e64-32s_v3,standard_e64-32s_v4,standard_e64-32s_v5,standard_e64_v3,standard_e64_v4,standard_e64_v5,standard_e64a_v4,standard_e64ads_v5,standard_e64as_v4,standard_e64as_v5,standard_e64bds_v5,standard_e64bs_v5,standard_e64d_v4,standard_e64d_v5,standard_e64ds_v4,standard_e64ds_v5,standard_e64i_v3,standard_e64is_v3,standard_e64pds_v6,standard_e64ps_v6,standard_e64s_v3,standard_e64s_v4,standard_e64s_v5,standard_e8-2ads_v5,standard_e8-2as_v4,standard_e8-2as_v5,standard_e8-2ds_v4,standard_e8-2ds_v5,standard_e8-2s_v3,standard_e8-2s_v4,standard_e8-2s_v5,standard_e8-4ads_v5,standard_e8-4as_v4,standard_e8-4as_v5,standard_e8-4ds_v4,standard_e8-4ds_v5,standard_e8-4s_v3,standard_e8-4s_v4,standard_e8-4s_v5,standard_e80ids_v4,standard_e80is_v4,standard_e8_v3,standard_e8_v4,standard_e8_v5,standard_e8a_v4,standard_e8ads_v5,standard_e8as_v4,standard_e8as_v5,standard_e8bds_v5,standard_e8bs_v5,standard_e8d_v4,standard_e8d_v5,standard_e8ds_v4,standard_e8ds_v5,standard_e8pds_v5,standard_e8pds_v6,standard_e8ps_v5,standard_e8ps_v6,standard_e8s_v3,standard_e8s_v4,standard_e8s_v5,standard_e96-24ads_v5,standard_e96-24as_v4,standard_e96-24as_v5,standard_e96-24ds_v5,standard_e96-24s_v5,standard_e96-48ads_v5,standard_e96-48as_v4,standard_e96-48as_v5,standard_e96-48ds_v5,standard_e96-48s_v5,standard_e96_v5,standard_e96a_v4,standard_e96ads_v5,standard_e96as_v4,standard_e96as_v5,standard_e96bds_v5,standard_e96bs_v5,standard_e96d_v5,standard_e96ds_v5,standard_e96ias_v4,standard_e96pds_v6,standard_e96ps_v6,standard_e96s_v5,standard_f16,standard_f16s,standard_f16s_v2,standard_f2,standard_f2s,standard_f2s_v2,standard_f32s_v2,standard_f4,standard_f48s_v2,standard_f4s,standard_f4s_v2,standard_f64s_v2,standard_f72s_v2,standard_f8,standard_f8s,standard_f8s_v2,standard_fx12mds,standard_fx24mds,standard_fx36mds,standard_fx48mds,standard_fx4mds,standard_hb120-16rs_v2,standard_hb120-32rs_v2,standard_hb120-64rs_v2,standard_hb120-96rs_v2,standard_hb120rs_v2,standard_hc44-16rs,standard_hc44-32rs,standard_hc44rs,standard_l16as_v3,standard_l16s_v2,standard_l16s_v3,standard_l32as_v3,standard_l32s_v2,standard_l32s_v3,standard_l48as_v3,standard_l48s_v2,standard_l48s_v3,standard_l64as_v3,standard_l64s_v2,standard_l64s_v3,standard_l80as_v3,standard_l80s_v2,standard_l80s_v3,standard_l8as_v3,standard_l8s_v2,standard_l8s_v3,standard_m128,standard_m128-32ms,standard_m128-64bds_3_v3,standard_m128-64bds_v3,standard_m128-64bs_v3,standard_m128-64ms,standard_m128bds_3_v3,standard_m128bds_v3,standard_m128bs_v3,standard_m128dms_v2,standard_m128ds_v2,standard_m128m,standard_m128ms,standard_m128ms_v2,standard_m128s,standard_m128s_v2,standard_m12ds_v3,standard_m12s_v3,standard_m16-4ms,standard_m16-8ms,standard_m16bds_v3,standard_m16bs_v3,standard_m16ms,standard_m176-88bds_4_v3,standard_m176-88bds_v3,standard_m176-88bs_v3,standard_m176bds_4_v3,standard_m176bds_v3,standard_m176bs_v3,standard_m176ds_3_v3,standard_m176ds_4_v3,standard_m176s_3_v3,standard_m176s_4_v3,standard_m192idms_v2,standard_m192ids_v2,standard_m192ims_v2,standard_m192is_v2,standard_m208ms_v2,standard_m208s_v2,standard_m24ds_v3,standard_m24s_v3,standard_m32-16ms,standard_m32-8ms,standard_m32bds_v3,standard_m32bs_v3,standard_m32dms_v2,standard_m32ls,standard_m32ms,standard_m32ms_v2,standard_m32ts,standard_m416-208ms_v2,standard_m416-208s_v2,standard_m416ds_6_v3,standard_m416ds_8_v3,standard_m416ms_v2,standard_m416s_6_v3,standard_m416s_8_v2,standard_m416s_8_v3,standard_m416s_v2,standard_m48bds_v3,standard_m48bs_v3,standard_m48ds_1_v3,standard_m48s_1_v3,standard_m624ds_12_v3,standard_m624s_12_v3,standard_m64,standard_m64-16ms,standard_m64-32bds_1_v3,standard_m64-32ms,standard_m64bds_1_v3,standard_m64bds_v3,standard_m64bs_v3,standard_m64dms_v2,standard_m64ds_v2,standard_m64ls,standard_m64m,standard_m64ms,standard_m64ms_v2,standard_m64s,standard_m64s_v2,standard_m8-2ms,standard_m8-4ms,standard_m832ds_12_v3,standard_m832ids_16_v3,standard_m832is_16_v3,standard_m832s_12_v3,standard_m8ms,standard_m96-48bds_2_v3,standard_m96bds_2_v3,standard_m96bds_v3,standard_m96bs_v3,standard_m96ds_1_v3,standard_m96ds_2_v3,standard_m96s_1_v3,standard_m96s_2_v3,standard_nc12s_v3,standard_nc16as_t4_v3,standard_nc24ads_a100_v4,standard_nc24rs_v3,standard_nc24s_v3,standard_nc40ads_h100_v5,standard_nc48ads_a100_v4,standard_nc4as_t4_v3,standard_nc64as_t4_v3,standard_nc6s_v3,standard_nc80adis_h100_v5,standard_nc8as_t4_v3,standard_nc96ads_a100_v4,standard_nd96amsr_a100_v4,standard_nd96asr_v4,standard_nv12ads_a10_v5,standard_nv12s_v3,standard_nv16as_v4,standard_nv18ads_a10_v5,standard_nv24s_v3,standard_nv32as_v4,standard_nv36adms_a10_v5,standard_nv36ads_a10_v5,standard_nv48s_v3,standard_nv4as_v4,standard_nv6ads_a10_v5,standard_nv72ads_a10_v5,standard_nv8as_v4'. Please refer to aka.ms/aks/vm-size-selector to find supported VM sizes in location 'westus2'.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, let's wait it till May according to the rule.
For the rp backend, only the region that already rolled out the default feature can support this from client.
If not, the backend will response VMSizeNotSupported

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the guidance to update PR title/description as it will be considered as history note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants